Skip to content

fix: restart LS on lib/core change, client re-init #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix: restart LS on lib/core change, client re-init #1808

merged 1 commit into from
Jan 16, 2023

Conversation

@kittaakos
Copy link
Contributor

Motivation

The running LS must be restarted on library/platform install/uninstall events and core client re-init events (the latter is fired when the sketchbook location changes in IDE2) so that IDE2 can provide the correct Arduino language features to the users.

Change description

  • force restart of the LS on core/lib changes,
  • and sketchbook location change
670.mp4

Other information

Closes #670

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: restart LS on lib/core change, client re-init
637e2cc 
Closes #670

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos requested review from AlbyIanna and per1234 January 9, 2023 09:50
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: language server Related to the Arduino Language Server labels Jan 9, 2023
AlbyIanna
AlbyIanna approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works for me. Code is also looking good ✅

per1234
per1234 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 432f365 into main Jan 16, 2023
@kittaakos kittaakos deleted the #670 branch January 16, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Language server results not updated after changes to installed libraries

3 participants

@kittaakos @AlbyIanna @per1234