Skip to content

Correct text of "INSTALLED" label in Library/Boards Manager #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Correct text of "INSTALLED" label in Library/Boards Manager #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Correct text of "INSTALLED" label in Library/Boards Manager 
An "INSTALLED" label is shown on the items in the Library Manager and Boards Manager views that are currently installed
on the user's system.

During some work to add missing internationalization to the UI strings, this text was changed to "INSTALL". That text is
not appropriate for what this label is intended to communicate.

The regression is hereby corrected, while retaining the internationalization of the string.
  • Loading branch information
@per1234
per1234 committed Sep 30, 2022
commit 5e0f1f2c0d5ad33392ecfd076b45b6863a16f6fd
2 changes: 1 addition & 1 deletion arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class ListItemRenderer<T extends ArduinoComponent> {
className="installed"
onClick={onClickUninstall}
{...{
install: nls.localize('arduino/component/install', 'INSTALL'),
install: nls.localize('arduino/component/installed', 'INSTALLED'),
uninstall: nls.localize('arduino/component/uninstall', 'Uninstall'),
}}
/>
Expand Down
1 change: 1 addition & 0 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"by": "by",
"filterSearch": "Filter your search...",
"install": "INSTALL",
"installed": "INSTALLED",
"moreInfo": "More info",
"uninstall": "Uninstall",
"uninstallMsg": "Do you want to uninstall {0}?",
Expand Down