Skip to content

fix 180: prevent erroneous "auto-reconnect"(s) in board selector #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 24, 2022
Merged
Prev Previous commit
Next Next commit
remove unused methods and deps
  • Loading branch information
davegarthsimpson committed Aug 16, 2022
commit b15603cce703c7087001bd0dc2039d86473e1d16
10 changes: 0 additions & 10 deletions arduino-ide-extension/src/browser/contributions/upload-sketch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { UserFieldsDialog } from '../dialogs/user-fields/user-fields-dialog';
import { DisposableCollection, nls } from '@theia/core/lib/common';
import { CurrentSketch } from '../../common/protocol/sketches-service-client-impl';
import type { VerifySketchParams } from './verify-sketch';
import { NotificationCenter } from '../notification-center';

@injectable()
export class UploadSketch extends CoreServiceContribution {
Expand All @@ -25,9 +24,6 @@ export class UploadSketch extends CoreServiceContribution {
@inject(UserFieldsDialog)
private readonly userFieldsDialog: UserFieldsDialog;

@inject(NotificationCenter)
private readonly notificationCenter: NotificationCenter;

private boardRequiresUserFields = false;
private readonly cachedUserFields: Map<string, BoardUserField[]> = new Map();
private readonly menuActionsDisposables = new DisposableCollection();
Expand Down Expand Up @@ -196,9 +192,6 @@ export class UploadSketch extends CoreServiceContribution {
this.uploadInProgress = true;
this.onDidChangeEmitter.fire();
this.clearVisibleNotification();
this.notificationCenter.notifyUploadAttemptInProgress(
this.uploadInProgress
);

const verifyOptions =
await this.commandService.executeCommand<CoreService.Options.Compile>(
Expand Down Expand Up @@ -251,9 +244,6 @@ export class UploadSketch extends CoreServiceContribution {
} finally {
this.uploadInProgress = false;
this.onDidChangeEmitter.fire();
this.notificationCenter.notifyUploadAttemptInProgress(
this.uploadInProgress
);
}
}

Expand Down
6 changes: 0 additions & 6 deletions arduino-ide-extension/src/node/notification-service-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ export class NotificationServiceServerImpl
);
}

notifyUploadAttemptInProgress(event: boolean): void {
this.clients.forEach((client) =>
client.notifyUploadAttemptInProgress(event)
);
}

setClient(client: NotificationServiceClient): void {
this.clients.push(client);
}
Expand Down