Skip to content

#1089: IDE falls back to new sketch if opening failed #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 18, 2022
Merged

#1089: IDE falls back to new sketch if opening failed #1152

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7a9a5e1
IDE2 falls back to new sketch if opening failed.
Jul 4, 2022
2d58929
no message check.
Jul 8, 2022
13232b7
open sketch files in dedicated contribution.
Jul 8, 2022
bf11597
moved LS to its own contribution.
Jul 8, 2022
baa9936
get rid of old editor mode. use a preference.
Jul 8, 2022
ba39909
moved selected board tracker to its module.
Jul 8, 2022
123ccb1
Use the default Theia spinner.
Jul 8, 2022
a12b1c9
missing translation for the new preference.
Jul 8, 2022
fe743f8
check for updates in own module.
Jul 8, 2022
198d52b
added todo.
Jul 8, 2022
b71e3ef
Fixed the typo in the preference key.
Jul 8, 2022
6268634
Fixed the translations.
Jul 8, 2022
cba1802
open boards config in own contribution.
Jul 8, 2022
f5a1f9e
tracking the sketch files has its own module.
Jul 8, 2022
8f93cf4
set zoom level after layout initialization.
Jul 8, 2022
8ac8211
first start installer has its own contribution.
Jul 8, 2022
eb89d85
Fix the incorrect error message from the CLI.
Jul 14, 2022
95d2862
no setTimeout
Jul 14, 2022
fa7f2e8
do not show error notification on sketch restore
Jul 15, 2022
e6c4d57
removed duplicate
Jul 18, 2022
824e55c
removed duplicate contribution
Jul 18, 2022
676b255
merged in `realTimeDiagnostics` support.
Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added todo. 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
  • Loading branch information
Akos Kitta committed Jul 18, 2022
commit 198d52b924e05fd09894bdbced776d41bf3b1faa
1 change: 1 addition & 0 deletions arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ export class ArduinoFrontendContribution
);
}

// TODO: should be handled by `Close` contribution. https://github.com/arduino/arduino-ide/issues/1016
onWillStop(): OnWillStopAction {
return {
reason: 'temp-sketch',
Expand Down