Skip to content

Survey notification implementation #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2022
Merged

Survey notification implementation #1035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e424b5f
survey notification implementation
francescospissu Jun 10, 2022
fb2d99d
update i18n/en.json with new strings
francescospissu Jun 10, 2022
f215547
survey implementation improvements
francescospissu Jun 13, 2022
ab3acda
add setting to disable surveys in advanced preferences
francescospissu Jun 14, 2022
fb7ec54
code clean up
francescospissu Jun 14, 2022
884a9e8
code clean up and i18n update
francescospissu Jun 14, 2022
e553139
avoid caps strings
francescospissu Jun 14, 2022
bda7f6b
avoid multiple notifications in different windows
francescospissu Jun 16, 2022
77698f8
document the purpose of the service
francescospissu Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid caps strings
  • Loading branch information
@francescospissu
francescospissu committed Jun 16, 2022
commit e5531396cdd4553211d1c5408f66f88ad4e45cc1
4 changes: 2 additions & 2 deletions arduino-ide-extension/src/browser/contributions/survey-notification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ const SURVEY_MESSAGE = nls.localize(
);
const DO_NOT_SHOW_AGAIN = nls.localize(
'arduino/survey/dismissSurvey',
"DON'T SHOW ANYMORE"
"Don't show again"
);
const GO_TO_SURVEY = nls.localize(
'arduino/survey/answerSurvey',
'ANSWER SURVEY'
'Answer survey'
);

const SURVEY_BASE_URL = 'https://surveys.hotjar.com/';
Expand Down
4 changes: 2 additions & 2 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@
"verifyOrCompile": "Verify/Compile"
},
"survey": {
"answerSurvey": "ANSWER SURVEY",
"dismissSurvey": "DON'T SHOW ANYMORE",
"answerSurvey": "Answer survey",
"dismissSurvey": "Don't show again",
"surveyMessage": "Please help us improve by answering this super short survey. We value our community and would like to get to know our supporters a little better."
},
"upload": {
Expand Down