"Find Next" has no effect

[per1234]

Describe the bug

The Edit > Find Next menu item is intended to find the next occurrence of the chosen text.

🐛 It currently has no effect.

To Reproduce

1. Select File > New from the Arduino IDE menus.
2. Select Edit > Find from the Arduino IDE menus.
   The "Find" UI opens with void pre-filled.
3. Select Edit > Find Next from the Arduino IDE menus.
   🐛 Nothing happens.
4. Select Edit > Find Next from the Arduino IDE menus.
   🐛 Nothing happens.
5. Select Edit > Find Previous from the Arduino IDE menus.
   🙂 The occurrence of void at line 1 is selected.
6. Select Edit > Find Previous from the Arduino IDE menus.
   🙂 The occurrence of void at line 6 is selected.
7. In the "Find" UI, click the ↓ icon.
   🙂 The occurrence of void at line 1 is selected.

Expected behavior

The same behavior from Edit > Find Next as from Edit > Find Previous, except in the opposite direction.

Desktop

Initial report

• OS: Windows 10
• IDE Version: 2.0.0-rc3
  Date: 2021-12-22T15:46:56.004Z
• Arduino CLI Version: 0.20.2 [13783819]

Last checked with

• OS: Windows 10
• Version: 2.0.0-rc3-snapshot-9ecff86
  Date: 2022-02-15T15:53:31.454Z
  CLI Version: 0.21.0 [10107d24]

[ubidefeo]

@per1234
I have tested this one on a recent PR build and it is working form the UI's arrows but the shortcut (CMD+G on Mac) is not honoured

[ubidefeo]

investigate if it's a bug/regression from Monaco editor, since when hitting the shortcut the popup opens with ? of X (see screenshot)
/Users/ubidefeo/Library/Application Support/CleanShot/media/media_ky5DPu4DMW/CleanShot 2022-02-17 at 11.55.31@2x.png

[per1234]

it is working form the UI's arrows

Same here, as I reported in step (7) in the instructions.

the shortcut (CMD+G on Mac) is not honoured

Same for me on Windows (Ctrl+G). I notice that there is a shortcut collision with the default shortcut for Go to Line/Column... (did anyone bother to check this stuff?), but even after I change Go to Line/Column... shortcut to something else Ctrl+G still doesn't do a "Find Next". Ctrl+Shift+G works just fine for "Find Previous".

when hitting the shortcut the popup opens with ? of X

@ubidefeo which shortcut?

@ubidefeo does it also happen with the File > New sketch, or only with that "NiclaShopSensor" sketch?

[msujew]

I fixed this and accidentally pushed to main ca1c240 directly. Please revert it, if you notice it does not work as expected or you want me to create a PR for this.

Additionally, you should probably mark main to be protected.

[AlbyIanna]

Thanks for the suggestion @msujew. I agree, we should protect main.

The commit seems pretty clean to me. If it works, I'd leave it there.

@per1234 @ubidefeo would you please help me give it a try?

[AlbyIanna]

I tested ca1c240 and it solves the issue for me.
Anyone interested in testing it can find the build here

[per1234]

Closing as fixed by ca1c240

Thanks @msujew!