Starting debug session saves without warning

[per1234]

Describe the problem

🐛 When you start a debug session with a dirty sketch, the sketch is automatically saved, even though the "Auto save" preference is disabled. Combined with the current behavior of compiling and uploading the saved version of the sketch (https://github.com/arduino/arduino-pro-ide/issues/432), this can be quite confusing.

To reproduce

1. Select File > Preferences... from the Arduino IDE menus.
2. Uncheck the box next to "Auto save".
3. Click the "OK" button.
4. Make a change to the sketch code.
   ❗ Don't save.
5. Click the "Start Debuging" button.

🐛 The dirty indicator disappears and the changes are saved to the sketch.

Expected behavior

Don't save the sketch when starting a debug session.

Arduino IDE version

Original report

0.1.4

Last verified with

9a6a457

Operating system

Windows

Operating system version

11

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[kittaakos]

Unlike in arduino/arduino-pro-ide#432, I can argue here as the behavior was not defined 15 years ago. This is how VS Code works.

[per1234]

How about a save confirmation dialog?

[kittaakos]

How about a save confirmation dialog?

Sure. That's possible of course.

[kittaakos]

Related: microsoft/vscode#111850

[ubidefeo]

@kittaakos we should directly save before every compile action.
So auto-save is good but it's up to the user to have it, but before compiling it should just do it

[kittaakos]

@kittaakos we should directly save before every compile action.
So auto-save is good but it's up to the user to have it, but before compiling it should just do it

I am not sure if I can follow you, @ubidefeo. (Related: https://github.com/arduino/arduino-pro-ide/issues/432#issuecomment-777281286). This is about debug and not compile.

[ubidefeo]

@kittaakos
I'll extend on this in another issue :)

[ubidefeo]

@per1234
I'm not sure this is still valid, since we reworked how we save files in tmp.
Let me know if it deserved a bump

[per1234]

@ubidefeo same problem as always even with the latest nightly build. Any unsaved changes are saved to the real sketch files without any warning when I click the "Start Debugging" button.