Migrate Nina firmwares to plugin system #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
umbynos
force-pushed
the
migrate-nina-fw-plugin
branch
from
0fb1e80 to
9397175
Compare
…ds.json` file This way we have to modify this file only to add support for new boards. The `generate_boards_json()` function have been split: this way we can remove the old one when the time comes.
umbynos
force-pushed
the
migrate-nina-fw-plugin
branch
from
9397175 to
bf3cd6f
Compare
umbynos
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=====================================
Coverage 6.63% 6.63%
=====================================
Files 24 24
Lines 2154 2154
=====================================
Hits 143 143
Misses 1953 1953
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
umbynos
force-pushed
the
migrate-nina-fw-plugin
branch
from
8eb340f to
bf3cd6f
Compare
2 tasks
umbynos
changed the title
alessio-perugini
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the
generate.pypython script to generate the required json file for theplugin_firmware_index.jsonfile.Along the way, I performed some optimizations. Further details in the commit messages.
Close #195