Skip to content

Update toneMelody.ino #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update toneMelody.ino #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update toneMelody.ino 
no more magic numbers for eg the buzzer pin
  • Loading branch information
@krekr
krekr authored Mar 19, 2021
commit 4b44385314637ad204c7e244c1dfd276a5dab929
10 changes: 7 additions & 3 deletions examples/02.Digital/toneMelody/toneMelody.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

#include "pitches.h"

int buzzerPin = 8;

// notes in the melody:
int melody[] = {
NOTE_C4, NOTE_G3, NOTE_G3, NOTE_A3, NOTE_G3, 0, NOTE_B3, NOTE_C4
Expand All @@ -27,21 +29,23 @@ int noteDurations[] = {
4, 8, 8, 4, 4, 4, 4, 4
};

int noteAmount = 8;

void setup() {
// iterate over the notes of the melody:
for (int thisNote = 0; thisNote < 8; thisNote++) {
for (int thisNote = 0; thisNote < noteAmount; thisNote++) {

// to calculate the note duration, take one second divided by the note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000 / noteDurations[thisNote];
tone(8, melody[thisNote], noteDuration);
tone(buzzerPin, melody[thisNote], noteDuration);

// to distinguish the notes, set a minimum time between them.
// the note's duration + 30% seems to work well:
int pauseBetweenNotes = noteDuration * 1.30;
delay(pauseBetweenNotes);
// stop the tone playing:
noTone(8);
noTone(buzzerPin);
}
}

Expand Down