Skip to content

Replace mitchellh/go used for macOS notarization #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Replace mitchellh/go used for macOS notarization #851

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06fc10e
switch to gon fork, apple is deprecating altool to notarize.
umbynos Nov 6, 2023
7059a50
use `ditto` to create archive:
umbynos Nov 6, 2023
308243b
remove stapling, we cannot staple a zip apparently
umbynos Nov 6, 2023
134d250
remove top level dir it's already there thanks to `ditto --keepParent
umbynos Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use ditto to create archive: 
https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/customizing_the_notarization_workflow
  • Loading branch information
@umbynos
umbynos committed Nov 6, 2023
commit 7059a5026f4ef25f08a65d47442e98822f273d82
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ jobs:
run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}"

- name: Zip output app bundle
run: zip ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip ArduinoCreateAgent.app
run: ditto -c -k --keepParent ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip

- name: Remove gon used for code signing
run: |
Expand Down