- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 157
 
Download the correct tools for Windows 64-bit #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download the correct tools for Windows 64-bit #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on the tests.
Did you have the chance of running the agent and see if this fix works?
| 
           Also I would aim to remove completely the   | 
    
2617f62    to
    19a25fe      
    Compare
  
    
          Codecov ReportPatch coverage:  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   10.96%   11.14%   +0.17%     
==========================================
  Files          55       53       -2     
  Lines        4066     4073       +7     
==========================================
+ Hits          446      454       +8     
+ Misses       3565     3563       -2     
- Partials       55       56       +1     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 ☔ View full report in Codecov by Sentry.  | 
    
Please check if the PR fulfills these requirements
before creating one)
Bug fix
Tools for Windows 32-bit are downloaded when the OS/Arch is Windows 64-bit.
The correct tools are downloaded for Windows 64-bit.
No