Skip to content

Remove installbuilder from macos release artifact #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 19, 2023
Merged

Remove installbuilder from macos release artifact #785

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a976fe9
let gon generate the dmg installer and upload it
umbynos May 5, 2023
eb6b8e9
package step does not need notarization anymore
umbynos May 5, 2023
214e0bd
remove installbuilder env vars related to macos
umbynos May 5, 2023
95321d6
remove macos from matrix
umbynos May 5, 2023
41e3181
remove macos related steps from package job
umbynos May 5, 2023
a8ab2eb
remove `executable-path` and `artifact-name` vars, they are redundant
umbynos May 5, 2023
bfcfbd6
remove `code-sign-mac-installers` job: we already have a notarized dmg
umbynos May 5, 2023
745e93e
adapt last `create-release` job
umbynos May 5, 2023
d057a01
Revert "let gon generate the dmg installer and upload it"
umbynos May 9, 2023
b05a2f9
add step to generate and sign the dmg installer
umbynos May 9, 2023
e9f318b
fix `create-release` job
umbynos May 9, 2023
a1ae0a9
Partially Revert "adapt last `create-release` job"
umbynos May 9, 2023
f822d9c
test new version of the installer config
umbynos May 9, 2023
2e1306b
Warn the user if a previous installation exists in `$HOME/Applications/`
umbynos May 16, 2023
8bf558d
Revert "test new version of the installer config"
umbynos May 9, 2023
fc49266
if the running binary is the old running one we don't do anything
umbynos May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
let gon generate the dmg installer and upload it
  • Loading branch information
@umbynos
umbynos committed May 19, 2023
commit a976fe96f51e5171865d7dcbd4242a028728a599
9 changes: 7 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,11 @@ jobs:
deep = true
}

# generate a Disk Image
dmg {
output_path = "ArduinoCreateAgent_${{ matrix.arch }}_notarized.dmg"
volume_name = "ArduinoCreateAgent"
}
# Ask Gon for zip output to force notarization process to take place.
# The CI will upload the zip output
zip {
Expand Down Expand Up @@ -317,11 +322,11 @@ jobs:
aws s3 cp darwin-${{ matrix.arch }}-bundle.json s3://${{ secrets.DOWNLOADS_BUCKET }}${{ env.TARGET }}
if: ${{ needs.build.outputs.prerelease != 'true' }}

- name: Upload artifact
- name: Upload artifacts
uses: actions/upload-artifact@v3
with:
name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized
path: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
path: ArduinoCreateAgent*_${{ matrix.arch }}_notarized.* #TODO remove zip upload (not needed here)
if-no-files-found: error

# This job is responsible for generating the installers (using installbuilder)
Expand Down