Add the ability to generate SSL certs from tray icon #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 11.33% 11.31% -0.03%
==========================================
Files 53 54 +1
Lines 3936 3943 +7
==========================================
Hits 446 446
- Misses 3435 3442 +7
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
umbynos
force-pushed
the
certs-from-tray
branch
from
9095a0b to
4abbcce
Compare
umbynos
force-pushed
the
certs-from-tray
branch
from
36e2509 to
3b2b74d
Compare
This way we have a single source of truth.
leverage objective C APIs to install our CA certificate in the user's trusted keystore
leverage windows syscalls to install our CA certificate in the user's trusted keystore code heavily inspired by https://github.com/FiloSottile/mkcert
umbynos
force-pushed
the
certs-from-tray
branch
5 times, most recently
from
21384b7 to
1829b03
Compare
|
Test release: |
umbynos
commented
Apr 18, 2023
umbynos
force-pushed
the
certs-from-tray
branch
from
4becc30 to
ae66104
Compare
|
I've removed support for windows in b6f6947 since the newer version of edge is chromium based: chromium and chrome do not require the agent in HTTPS |
umbynos
force-pushed
the
certs-from-tray
branch
3 times, most recently
from
80311ea to
d2c63ee
Compare
cmaglie
force-pushed
the
certs-from-tray
branch
from
d2c63ee to
087c88f
Compare
…that in the installer)
This reverts commit bcaeb75.
umbynos
force-pushed
the
certs-from-tray
branch
from
087c88f to
4016f2c
Compare
umbynos
force-pushed
the
certs-from-tray
branch
from
4016f2c to
bda1574
Compare
cmaglie
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
feature
Fix #735
There is a new clickable voice in the tray icon's menu that allows a Mac/
windowsuser to generate and install in the keychain the SSL certificates that are used for the agent to work in HTTPS mode.Linux has this menuItem disabled, since the certificates are not required on this OS.
The voice is clickable only if the certs have not already been generated, otherwise it's grayed-out
yes, the installation of the certs have been removed from the installer. It is now available from the tray icon. The doc have to be updated, if the user wants to remove the installed cert it has to be done manually using the keychain management tool of the system.
In the installer, we should remove the cert handling. (the 3 different flavors of the agent are no more required), also the CI needs some changes