Skip to content

Updater requests elevation if needed (issue 981) #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build on non-windows devices
Signed-off-by: Reginald Gillespie <109245101+Reginald-Gillespie@users.noreply.github.com>
  • Loading branch information
Reginald-Gillespie committed Mar 26, 2025
commit a5fb2d2bfed58a8820ddbadaf644ee5b5fbc72f8
17 changes: 17 additions & 0 deletions updater/elevate_unix.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//go:build !windows

package updater

import (
"os"
"os/exec"
)

func elevate() error {
args := append([]string{os.Args[0]}, os.Args[1:]...)
cmd := exec.Command("sudo", args...)
cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
return cmd.Run()
}
32 changes: 32 additions & 0 deletions updater/elevate_windows.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package updater

import (
"os"
"strings"
"syscall"

"golang.org/x/sys/windows"
)

func elevate() error {
verb := "runas"
exe, _ := os.Executable()
cwd, _ := os.Getwd()
args := strings.Join(os.Args[1:], " ")

verbPtr, err := syscall.UTF16PtrFromString(verb)
if err != nil {
return err
}
exePtr, err := syscall.UTF16PtrFromString(exe)
if err != nil {
return err
}
cwdPtr, err := syscall.UTF16PtrFromString(cwd)
if err != nil {
return err
}
argPtr, _ := syscall.UTF16PtrFromString(args)
var showCmd int32 = 1
return windows.ShellExecute(0, verbPtr, exePtr, argPtr, cwdPtr, showCmd)
}
44 changes: 2 additions & 42 deletions updater/updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,9 @@ import (
"io"
"net/http"
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
"syscall"

"golang.org/x/sys/windows"

log "github.com/sirupsen/logrus"
)
Expand Down Expand Up @@ -120,47 +116,11 @@ func copyExe(from, to string) error {
// requestElevation requests this program to rerun as administrator, for when we don't have permission over the update files
func requestElevation() {
log.Println("Permission denied. Requesting elevated privileges...")
var err error
if runtime.GOOS == "windows" {
err = elevateWindows()
} else {
err = elevateUnix()
}

var err error = elevate()

if err != nil {
log.Println("Failed to request elevation:", err)
return
}
}

func elevateWindows() error {
verb := "runas"
exe, _ := os.Executable()
cwd, _ := os.Getwd()
args := strings.Join(os.Args[1:], " ")

verbPtr, err := syscall.UTF16PtrFromString(verb)
if err != nil {
return err
}
exePtr, err := syscall.UTF16PtrFromString(exe)
if err != nil {
return err
}
cwdPtr, err := syscall.UTF16PtrFromString(cwd)
if err != nil {
return err
}
argPtr, _ := syscall.UTF16PtrFromString(args)
var showCmd int32 = 1
return windows.ShellExecute(0, verbPtr, exePtr, argPtr, cwdPtr, showCmd)
}

func elevateUnix() error {
args := append([]string{os.Args[0]}, os.Args[1:]...)
cmd := exec.Command("sudo", args...)
cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
return cmd.Run()
}
Loading