Skip to content

Refactor config init command #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 26, 2021
Merged

Refactor config init command #68

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
71782ac
Get default arduino15 folder
polldo Nov 23, 2021
07f0c8e
Set arduino15 as default config dir
polldo Nov 23, 2021
05a817e
Get id and secret from prompt
polldo Nov 23, 2021
ffe1572
Refactor cli config
polldo Nov 24, 2021
bf6ffc5
Fix error formatting
polldo Nov 24, 2021
da8f312
Export arduino DataDir
polldo Nov 25, 2021
2c3895d
Update cli/config/init.go
Nov 25, 2021
842e213
Update cli/config/init.go
Nov 25, 2021
4bcc7ba
Update cli/config/init.go
Nov 25, 2021
6a2a541
Improve errors and feedback
polldo Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve errors and feedback
  • Loading branch information
@polldo
polldo committed Nov 25, 2021
commit 6a2a541c68f376a6b68809fb58fe465b01806ea5
13 changes: 7 additions & 6 deletions cli/config/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,31 +76,32 @@ func runInitCommand(cmd *cobra.Command, args []string) {
// Validate format flag
initFlags.format = strings.ToLower(initFlags.format)
if initFlags.format != "json" && initFlags.format != "yaml" {
feedback.Error("Error during config init: the provided format is not valid, it should be 'json' or 'yaml'")
feedback.Error("Error during config init: format is not valid, provide 'json' or 'yaml'")
os.Exit(errorcodes.ErrGeneric)
}

// Check that the destination directory is valid and build the configuration file path
configPath, err := paths.New(initFlags.destDir).Abs()
if err != nil {
feedback.Errorf("Error during config init: cannot retrieve absolute path of dest-dir: %v", err)
feedback.Errorf("Error during config init: cannot retrieve absolute path of %s: %v", initFlags.destDir, err)
os.Exit(errorcodes.ErrGeneric)
}
if !configPath.IsDir() {
feedback.Error("Error during config init: passed dest-dir is not a valid directory")
feedback.Errorf("Error during config init: %s is not a valid directory", configPath)
os.Exit(errorcodes.ErrGeneric)
}
configFile := configPath.Join(config.Filename + "." + initFlags.format)
if !initFlags.overwrite && configFile.Exist() {
feedback.Error("Error during config init: config file already exists, use --overwrite to discard the existing one")
feedback.Errorf("Error during config init: %s already exists, use '--overwrite' to overwrite it",
configFile)
os.Exit(errorcodes.ErrGeneric)
}

// Take needed configuration parameters starting an interactive mode
feedback.Print("To obtain your API credentials visit https://create.arduino.cc/iot/integrations")
id, key, err := paramsPrompt()
if err != nil {
feedback.Errorf("Error during config init: taking config parameters: %v", err)
feedback.Errorf("Error during config init: cannot take config params: %v", err)
os.Exit(errorcodes.ErrGeneric)
}

Expand All @@ -114,7 +115,7 @@ func runInitCommand(cmd *cobra.Command, args []string) {
os.Exit(errorcodes.ErrGeneric)
}

logrus.Infof("Config file successfully initialized at: %s", configFile.String())
feedback.Printf("Config file successfully initialized at: %s", configFile)
}

func paramsPrompt() (id, key string, err error) {
Expand Down