Improve resource deletion flow #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Giuseppe Lumia <g.lumia@outlook.com>
polldo
force-pushed
the
polldo/improve-delete
branch
from
da94a57 to
e1a8469
Compare
glumia
approved these changes
Nov 23, 2021
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Co-authored-by: Giuseppe Lumia <g.lumia@outlook.com>
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Co-authored-by: Giuseppe Lumia <g.lumia@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I forgot about #54 (comment)
we want to improve the readability of the flow
also this change allows a more easy introduction of bulk device deletion (still not requested)
Change description
improve readability
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.