Skip to content

Improve struct comments #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

Improve struct comments #36

merged 1 commit into from
Sep 17, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Sep 17, 2021

Motivation

Improve struct comments for readability as suggested here

Change description

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from glumia September 17, 2021 15:36
glumia
glumia approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@glumia glumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)

@polldo
Copy link
Contributor Author

polldo commented Sep 17, 2021

@glumia as always, thanks for the suggestion !

@polldo polldo merged commit 965ce65 into main Sep 17, 2021
@polldo polldo deleted the polldo/improve-comment branch September 17, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@glumia glumia glumia approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polldo @glumia