Skip to content

Improve output format #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 13, 2021
Merged

Improve output format #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f7a9d77
Replace fmt print into log info
polldo Sep 8, 2021
fb1d716
Distinguish board from device
polldo Sep 8, 2021
7801fce
Improve device format output
polldo Sep 8, 2021
7293f81
Fix log infof
polldo Sep 8, 2021
179f886
Improve logs of arduino-cli
polldo Sep 8, 2021
9c719b1
Fix log msg
polldo Sep 8, 2021
6690306
Update go mod
polldo Sep 8, 2021
69d71b0
Improve thing output format
polldo Sep 8, 2021
493689c
Refactor thing output format
polldo Sep 8, 2021
29b415d
Fix device iot client
polldo Sep 8, 2021
370916c
Improve errors: use stderr and error codes
polldo Sep 10, 2021
c318bbc
cli package: don't return error
polldo Sep 10, 2021
37bd229
Remove unreachable code
polldo Sep 10, 2021
887249d
Improve log initialization
polldo Sep 10, 2021
01c92f0
Remove duplication of info messages
polldo Sep 10, 2021
1787c4f
Add arduino-cli source to upload logs
polldo Sep 10, 2021
5d10e44
Return consistent output
polldo Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplication of info messages
  • Loading branch information
@polldo
polldo committed Sep 10, 2021
commit 01c92f0cf4c026b04dccf58edf71a80e33e96495
3 changes: 1 addition & 2 deletions cli/device/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ func runCreateCommand(cmd *cobra.Command, args []string) {
os.Exit(errorcodes.ErrGeneric)
}

logrus.Infof("IoT Cloud device created with ID: %s\n", dev.ID)
feedback.PrintResult(createResult{dev})
}

Expand All @@ -63,5 +62,5 @@ func (r createResult) Data() interface{} {
}

func (r createResult) String() string {
return fmt.Sprintf("IoT Cloud device created with ID: %s\n", r.device.ID)
return fmt.Sprintf("IoT Cloud device created with ID: %s", r.device.ID)
}
1 change: 0 additions & 1 deletion cli/thing/clone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func runCloneCommand(cmd *cobra.Command, args []string) {
os.Exit(errorcodes.ErrGeneric)
}

logrus.Infof("IoT Cloud thing created with ID: %s", thing.ID)
feedback.PrintResult(cloneResult{thing})
}

Expand Down
1 change: 0 additions & 1 deletion cli/thing/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func runCreateCommand(cmd *cobra.Command, args []string) {
os.Exit(errorcodes.ErrGeneric)
}

logrus.Infof("IoT Cloud thing created with ID: %s\n", thing.ID)
feedback.PrintResult(createResult{thing})
}

Expand Down