-
-
Couldn't load subscription status.
- Fork 431
Add support for i18n in the cli #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested:
task i18n:update(sotr(..)andi18n.Tr(..)calls detection)task i18n:pushandpullfrom transifex- PR sanity check on CI (checks fail if the submitter didn't run
i18n:update) - various extreme conditions on missing translations
- language setting detection on Linux
I did not test:
- language settings detection on Windows and Mac
- daily translation push to transifex
- weekly translations pull from transifex into a PR
BTW I think that the above may be fixed in a later PR (if needed) after testing the whole system for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Using the function
i18n.Tr("message", ...)its now possible to have localised messages in the cli.Localisation files are generated for each supported language.
What is the current behavior?
No i18n support
What is the new behavior?
To localise messages, use the function
i18n.Tr. The message will be localised with the locale set viai18n.SetLocale(..)Does this PR introduce a breaking change?
No
Other information:
See how to contribute