Skip to content

Added configuration option for proxy usage #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Added configuration option for proxy usage #609

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2237ca2
Update go-downloader to 1.2.0
cmaglie Mar 6, 2020
464dbb5
Use downloader.SetDefaultConfig() to set user-agent for the arduino-cli
cmaglie Mar 6, 2020
3b4c4e2
Add support for network proxy configuration
cmaglie Mar 6, 2020
cbf387a
Cosmetic: added blank space in configuration/defaults.go
cmaglie Mar 6, 2020
0b8cd8d
Refactored function to generate user-agent
cmaglie Mar 6, 2020
0f0dd75
Added a TODO for missing proxy usage in board list API query
cmaglie Mar 6, 2020
16e0871
Partially revert global network configuration.
cmaglie Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added a TODO for missing proxy usage in board list API query
  • Loading branch information
@cmaglie
cmaglie committed Apr 15, 2020
commit 0f0dd7504b81c05f8c1ad6f46c19554d68269868
2 changes: 2 additions & 0 deletions commands/board/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ func apiByVidPid(vid, pid string) ([]*rpc.BoardListItem, error) {
req.Header = globals.NewHTTPClientHeader("")
req.Header.Set("Content-Type", "application/json")

// TODO: use proxy if set

if res, err := http.DefaultClient.Do(req); err == nil {
if res.StatusCode >= 400 {
if res.StatusCode == 404 {
Expand Down