moved core tests to pytest

cli/cli_test.go

@@ -34,7 +34,6 @@ import (
 	"github.com/arduino/arduino-cli/cli/feedback"
 
 	"bou.ke/monkey"
-	paths "github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
 	semver "go.bug.st/relaxed-semver"
 )
@@ -292,42 +291,6 @@ func TestUploadIntegration(t *testing.T) {
 	require.NotZero(t, exitCode)
 }
 
-func TestInvalidCoreURLIntegration(t *testing.T) {
-	configFile := filepath.Join("testdata", t.Name())
-
-	// Dump config with cmd-line specific file
-	exitCode, d := executeWithArgs("--config-file", configFile, "config", "dump")
-	require.Zero(t, exitCode)
-	require.Contains(t, string(d), "- http://www.invalid-domain-asjkdakdhadjkh.com/package_example_index.json")
-
-	// Update inexistent index
-	exitCode, _ = executeWithArgs("--config-file", configFile, "core", "update-index")
-	require.NotZero(t, exitCode)
-}
-
-func Test3rdPartyCoreIntegration(t *testing.T) {
-	configFile := filepath.Join("testdata", t.Name())
-
-	// Update index and install esp32:esp32
-	exitCode, _ := executeWithArgs("--config-file", configFile, "core", "update-index")
-	require.Zero(t, exitCode)
-	exitCode, d := executeWithArgs("--config-file", configFile, "core", "install", "esp32:esp32")
-	require.Zero(t, exitCode)
-	require.Contains(t, string(d), "installed")
-
-	// Build a simple sketch and check if all artifacts are copied
-	tmp := tmpDirOrDie()
-	defer os.RemoveAll(tmp)
-	tmpSketch := paths.New(tmp).Join("Blink")
-	err := paths.New("testdata/Blink").CopyDirTo(tmpSketch)
-	require.NoError(t, err, "copying test sketch into temp dir")
-	exitCode, d = executeWithArgs("--config-file", configFile, "compile", "-b", "esp32:esp32:esp32", tmpSketch.String())
-	require.Zero(t, exitCode)
-	require.True(t, tmpSketch.Join("Blink.esp32.esp32.esp32.bin").Exist())
-	require.True(t, tmpSketch.Join("Blink.esp32.esp32.esp32.elf").Exist())
-	require.True(t, tmpSketch.Join("Blink.esp32.esp32.esp32.partitions.bin").Exist()) // https://github.com/arduino/arduino-cli/issues/163
-}
-
 func TestCoreCommandsIntegration(t *testing.T) {
 	exitCode, _ := executeWithArgs("core", "update-index")
 	require.Zero(t, exitCode)

test/test_core.py

@@ -12,6 +12,8 @@
 # otherwise use the software for commercial activities involving the Arduino
 # software without disclosing the source code of your own applications. To purchase
 # a commercial license, send an email to license@arduino.cc.
+import os
+
 import pytest
 import simplejson as json
 
@@ -95,3 +97,32 @@ def test_core_search_no_args(run_command):
             break
     assert found
     assert len(platforms) == num_platforms
+
+
+def test_core_updateindex_invalid_url(run_command):
+    url = "http://www.invalid-domain-asjkdakdhadjkh.com/package_example_index.json"
+    result = run_command("core update-index --additional-urls={}".format(url))
+    assert result.failed
+
+
+def test_core_install_esp32(run_command, data_dir):
+    # update index
+    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
+    result = run_command("core update-index --additional-urls={}".format(url))
+    assert result.ok
+    # install 3rd-party core
+    result = run_command("core install esp32:esp32 --additional-urls={}".format(url))
+    assert result.ok
+
+    # create a sketch and compile to double check the core was successfully installed
+    sketch_path = os.path.join(data_dir, "test_core_install_esp32")
+    result = run_command("sketch new {}".format(sketch_path))
+    assert result.ok
+    result = run_command("compile -b esp32:esp32:esp32 {}".format(sketch_path))
+    assert result.ok
+    # prevent regressions for https://github.com/arduino/arduino-cli/issues/163
+    assert os.path.exists(
+        os.path.join(
+            sketch_path, "test_core_install_esp32.esp32.esp32.esp32.partitions.bin"
+        )
+    )