-
-
Notifications
You must be signed in to change notification settings - Fork 415
Command sketch new
do not join sketchbook path to sketch name if only sketchname is provided
#396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dbacd62
poc of required mod for behavior alignment
5aae182
align current tests to new behaviour
142d440
align sketch new behaviour in sketch path parameter mangling adding p…
a16bc66
align sketch new behaviour in sketch path parameter mangling adding
0343785
add test for subpath
c9f2cd9
add fix test for subpath
24c337f
add `.ino` suffix trim
f4b227c
move sketch new test in separate test_new.py file
5a2eca1
add working_dir fixture to sandboxing sketch creation tests
f10ccc2
add e2e test for .ino strip
5d2664b
apply test_sketch.py to sketch test module name for consistency
c8ecd7f
update test lib invoke to 1.3.0 in requirements.txt
865b868
force pytest temp directory to be created in current dir
8fb0881
create local tmpdir only for windows-2019 VM
e21f5f0
add conditional step to test pipeline to overcome win VM behaviour in…
0c75cca
skip failing sketch new e2e tests in GA Win VM until we find the issu…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move sketch new test in separate test_new.py file
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# This file is part of arduino-cli. | ||
# | ||
# Copyright 2019 ARDUINO SA (http://www.arduino.cc/) | ||
# | ||
# This software is released under the GNU General Public License version 3, | ||
# which covers the main part of arduino-cli. | ||
# The terms of this license can be found at: | ||
# https://www.gnu.org/licenses/gpl-3.0.en.html | ||
# | ||
# You can be released from the requirements of the above licenses by purchasing | ||
# a commercial license. Buying such a license is mandatory if you want to modify or | ||
# otherwise use the software for commercial activities involving the Arduino | ||
# software without disclosing the source code of your own applications. To purchase | ||
# a commercial license, send an email to license@arduino.cc. | ||
import os | ||
|
||
|
||
def test_sketch_new(run_command): | ||
# Create a test sketch in current directory | ||
current_path = os.getcwd() | ||
sketch_name = "SketchNewIntegrationTest" | ||
current_sketch_path = os.path.join(current_path, sketch_name) | ||
result = run_command("sketch new {}".format(sketch_name)) | ||
assert result.ok | ||
assert "Sketch created in: {}".format(current_sketch_path) in result.stdout | ||
assert os.path.isfile(os.path.join(current_sketch_path, sketch_name + ".ino")) | ||
|
||
# Create a test sketch in current directory but using an absolute path | ||
sketch_name = "SketchNewIntegrationTestAbsolute" | ||
current_sketch_path = os.path.join(current_path, sketch_name) | ||
result = run_command("sketch new {}".format(current_sketch_path)) | ||
assert result.ok | ||
assert "Sketch created in: {}".format(current_sketch_path) in result.stdout | ||
assert os.path.isfile(os.path.join(current_sketch_path, sketch_name + ".ino")) | ||
|
||
# Create a test sketch in current directory subpath but using an absolute path | ||
sketch_name = "SketchNewIntegrationTestSubpath" | ||
sketch_subpath = os.path.join("subpath", sketch_name) | ||
current_sketch_path = os.path.join(current_path, sketch_subpath) | ||
result = run_command("sketch new {}".format(sketch_subpath)) | ||
assert result.ok | ||
assert "Sketch created in: {}".format(current_sketch_path) in result.stdout | ||
assert os.path.isfile(os.path.join(current_sketch_path, sketch_name + ".ino")) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we name this
test_sketch.py
for consistency?