Skip to content

bugfix: Kill compile processes that generates too much output #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

bugfix: Kill compile processes that generates too much output #2883

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a634d6
Added integration test
cmaglie Apr 10, 2025
f49fe0a
Fixed linter warning
cmaglie Apr 10, 2025
a8ed5e6
bugfix: Kill compile processes that generates too much output
cmaglie Apr 10, 2025
87f2935
Apply suggestion from code review
cmaglie Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestion from code review
  • Loading branch information
@cmaglie
cmaglie committed May 12, 2025
commit 87f29357bc60475c6ffb83d03e2e241b02fb2cf0
2 changes: 1 addition & 1 deletion internal/arduino/builder/internal/preprocessor/gcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ func GCC(
n, err := stderr.Write(p)
count += n
if count > 100*1024 {
cancel()
fmt.Fprintln(stderr, i18n.Tr("Compiler error output has been truncated."))
cancel()
}
return n, err
})
Expand Down