Skip to content

Turn Sketch commands into builder API functions #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 12, 2019
Merged

Turn Sketch commands into builder API functions #265

merged 15 commits into from
Jul 12, 2019

Conversation

@masci
Copy link
Contributor

@masci masci commented Jul 4, 2019 •
edited
Loading

Removed the following commands:

  • SketchSaver
  • SketchLoader
  • SketchSourceMerger

Added the following APIs:

  • arduino.builder.SaveSketchItemCpp
  • arduino.builder.LoadSketch
  • arduino.builder.MergeSketchSources

Packages added:

  • arduino.globals to define global const values
  • arduino.sketch to hold sketch types, will eventually include and supersede arduino.sketches

@masci masci marked this pull request as ready for review July 8, 2019 14:57
mastrolinux
mastrolinux reviewed Jul 9, 2019
View reviewed changes
rsora
rsora approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, totally endorsing the API approach instead of the OO "command" approach that can affect the understanding of how the builder modules work.

@rsora
Copy link
Contributor

rsora commented Jul 10, 2019

@ArduinoBot build this please

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-146-PR265-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-146-PR265-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-146-PR265-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-146-PR265-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-146-PR265-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@mastrolinux mastrolinux merged commit 1628b39 into master Jul 12, 2019
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-147-PR265-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-147-PR265-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-147-PR265-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-147-PR265-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-147-PR265-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@masci masci deleted the massi/sketch branch July 15, 2019 12:59
mastrolinux added a commit that referenced this pull request Jul 16, 2019
@mastrolinux
Merge pull request #265 from arduino/massi/sketch
c0a1d4f 
Turn Sketch commands into builder API functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mastrolinux mastrolinux mastrolinux left review comments

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@masci @rsora @ArduinoBot @mastrolinux