Skip to content

Fixed sketch compile with broken symlink #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Fixed sketch compile with broken symlink #2497

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db10911
Removed unneeded pointer
cmaglie Jan 11, 2024
49da311
Improved error message
cmaglie Jan 11, 2024
134c1e6
Update go-paths library
cmaglie Jan 12, 2024
5815018
Added integration tests
cmaglie Jan 11, 2024
9c1d4c3
Reduced timeout for symlink-loop tests
cmaglie Jan 11, 2024
f5bdaa7
Fixed unit tests
cmaglie Jan 12, 2024
754e35d
Fixed integration test
cmaglie Jan 13, 2024
e9dc764
Removed apparently useless check for "readable" files
cmaglie Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved error message
  • Loading branch information
@cmaglie
cmaglie committed Jan 16, 2024
commit 49da311294bebe058b894ceff52a6418f0ac1718
2 changes: 1 addition & 1 deletion internal/arduino/sketch/sketch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func New(path *paths.Path) (*Sketch, error) {

sketchFolderFiles, err := sketch.supportedFiles()
if err != nil {
return nil, err
return nil, fmt.Errorf("%s: %w", tr("reading sketch files"), err)
}

// Collect files
Expand Down