-
-
Couldn't load subscription status.
- Fork 431
[breaking] Eliminate BoardListWatchRequest Interrupt from the grpc api and make it server streaming only
#2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 63.08% 63.07% -0.01%
==========================================
Files 200 201 +1
Lines 19260 19233 -27
==========================================
- Hits 12150 12132 -18
+ Misses 6061 6050 -11
- Partials 1049 1051 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
9e61ef6 to
6c32a9c
Compare
Interrupt from the grpc api and make it server streaming only
|
Remember to update the PR message and update |
Interrupt from the grpc api and make it server streaming onlyInterrupt from the grpc api and make it server streaming only

Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
We removed the streaming part of the client side.
What is the current behavior?
We have bidirectional streaming of client<-> server and we leverage the use of
Interruptfield to stop the communication.What is the new behavior?
We simply make this server streaming only and we remove the Interrupt field from the API.
Does this PR introduce a breaking change, and is titled accordingly?
We removed the
Interruptfield fromBoardListWatchRequestmessage.We removed the stream of BoardListWatchRequest in the
BoardListWatchrpc:rpc BoardListWatch(BoardListWatchRequest) returns (stream BoardListWatchResponse);Other information