-
-
Couldn't load subscription status.
- Fork 431
legacy: Make a lot of Builder internals private #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some tests are failing |
41e1f49 to
873d1d3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2325 +/- ##
=======================================
Coverage 63.03% 63.04%
=======================================
Files 201 201
Lines 19264 19260 -4
=======================================
- Hits 12143 12142 -1
+ Misses 6067 6065 -2
+ Partials 1054 1053 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
It made most of the builder internals private. It will allow future refactorings without worrying about breaking changes in the golang API.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information