Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Add profiles to LoadSketchResponse #2264

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Aug 14, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

gRPC code enhancement

What is the new behavior?

Informations on profiles (name, fqbn, required platforms and libraries) can be retrieved through the LoadSketchResponse.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface labels Aug 14, 2023
@MatteoPologruto MatteoPologruto self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (38479dc) 62.93% compared to head (3a06f96) 62.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
+ Coverage   62.93%   62.98%   +0.05%     
==========================================
  Files         221      221              
  Lines       19730    19746      +16     
==========================================
+ Hits        12418    12438      +20     
+ Misses       6209     6206       -3     
+ Partials     1103     1102       -1     
Flag Coverage Δ
unit 62.98% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
commands/sketch/load.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto force-pushed the load-sketch-profile branch 3 times, most recently from cd5dcca to cfd0da2 Compare August 16, 2023 08:11
@MatteoPologruto MatteoPologruto merged commit 086b77a into arduino:master Aug 21, 2023
94 checks passed
@MatteoPologruto MatteoPologruto deleted the load-sketch-profile branch August 21, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants