-
-
Couldn't load subscription status.
- Fork 431
Fix double 100% progress on CompileResponse #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
- Coverage 62.97% 62.95% -0.02%
==========================================
Files 220 220
Lines 19501 19538 +37
==========================================
+ Hits 12280 12300 +20
- Misses 6137 6149 +12
- Partials 1084 1089 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a9f606c to
c7a7212
Compare
6442ed0 to
d1a7a6a
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fixes double 100% status on task upgrade when compiling
What is the current behavior?
Right now the
buildercommand calls therunCommands2 times which leads to having 2 100% values.What is the new behavior?
The new behavior only sends 1 100% task status and
completedproperty at true when done. I intentionally didn't try to refactor this legacy component.Does this PR introduce a breaking change, and is titled accordingly?
Other information