-
-
Couldn't load subscription status.
- Fork 431
Added gRPC command SetSketchDefaults to change sketch attached board/port
#2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The required information are returned from LoadSketch.
ea6768e to
c03ac6a
Compare
This allows to finally remove wrong access to `sketch.Sketch` from `cli` package.
c03ac6a to
54c4d8f
Compare
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>
935c5b9 to
a10a229
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
=======================================
Coverage 62.90% 62.91%
=======================================
Files 218 220 +2
Lines 19452 19477 +25
=======================================
+ Hits 12237 12254 +17
- Misses 6134 6139 +5
- Partials 1081 1084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Added gRPC API to automatically amend the project file
sketch.yamlwhile running theboard attachcommands.This change removes some of the gRPC API bypasses.
What is the current behavior?
What is the new behavior?
No changes
Does this PR introduce a breaking change, and is titled accordingly?
Yes, a small change in golang API.
Other information