-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Check cross-platform compatibility of sketch names #2216
Merged
MatteoPologruto
merged 3 commits into
arduino:master
from
MatteoPologruto:cross-platform-sketch-name
Jun 20, 2023
Merged
[breaking] Check cross-platform compatibility of sketch names #2216
MatteoPologruto
merged 3 commits into
arduino:master
from
MatteoPologruto:cross-platform-sketch-name
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Proposed improvement
topic: documentation
Related to documentation for the project
labels
Jun 14, 2023
MatteoPologruto
requested review from
cmaglie,
alessio-perugini,
per1234 and
umbynos
June 14, 2023 16:13
3 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
+ Coverage 62.90% 63.06% +0.15%
==========================================
Files 218 220 +2
Lines 19452 19481 +29
==========================================
+ Hits 12237 12285 +48
+ Misses 6134 6116 -18
+ Partials 1081 1080 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
umbynos
approved these changes
Jun 14, 2023
per1234
previously requested changes
Jun 14, 2023
cmaglie
reviewed
Jun 15, 2023
MatteoPologruto
force-pushed
the
cross-platform-sketch-name
branch
from
June 19, 2023 08:12
6a28502
to
a5a3b96
Compare
MatteoPologruto
force-pushed
the
cross-platform-sketch-name
branch
from
June 19, 2023 08:53
081806e
to
3ab1d33
Compare
MatteoPologruto
force-pushed
the
cross-platform-sketch-name
branch
from
June 19, 2023 12:05
3ab1d33
to
a2aab05
Compare
cmaglie
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
topic: documentation
Related to documentation for the project
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Documentation enhancement
What is the current behavior?
Sketch names ending with a
.
can be used. Reserved names can be used as sketch names.What is the new behavior?
It is no longer possible to name sketches in the above mentioned way.
Does this PR introduce a breaking change, and is titled accordingly?
Yes