-
-
Couldn't load subscription status.
- Fork 431
[breaking] Check cross-platform compatibility of sketch names #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Check cross-platform compatibility of sketch names #2216
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
+ Coverage 62.90% 63.06% +0.15%
==========================================
Files 218 220 +2
Lines 19452 19481 +29
==========================================
+ Hits 12237 12285 +48
+ Misses 6134 6116 -18
+ Partials 1081 1080 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6a28502 to
a5a3b96
Compare
081806e to
3ab1d33
Compare
3ab1d33 to
a2aab05
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Documentation enhancement
What is the current behavior?
Sketch names ending with a
.can be used. Reserved names can be used as sketch names.What is the new behavior?
It is no longer possible to name sketches in the above mentioned way.
Does this PR introduce a breaking change, and is titled accordingly?
Yes