Return exit code 0 when a core is already up to date #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alessio-perugini
added
the
type: imperfection
alessio-perugini
commented
Jun 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
- Coverage 62.98% 62.93% -0.06%
==========================================
Files 218 218
Lines 19466 19472 +6
==========================================
- Hits 12261 12254 -7
- Misses 6122 6137 +15
+ Partials 1083 1081 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
per1234
added
topic: code
alessio-perugini
force-pushed
the
2086-improve-the-message-printed-when-a-core-is-already-up-to-date
branch
3 times, most recently
from
874a381 to
17a7f3f
Compare
alessio-perugini
force-pushed
the
2086-improve-the-message-printed-when-a-core-is-already-up-to-date
branch
from
17a7f3f to
27f9b05
Compare
…de might be wrapped errors.As search through all the wrapped error for our target type, in case it finds it then it popolate that struct but more important we can use it as a type assertion even if is nested through many errors
cmaglie
approved these changes
Jun 14, 2023
alessio-perugini
deleted the
2086-improve-the-message-printed-when-a-core-is-already-up-to-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Return exit code 0 if a platform is already at the latest version
What is the current behavior?
Returns exit code 1.
What is the new behavior?
Returns exit code 0.
Does this PR introduce a breaking change, and is titled accordingly?
Other information