Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the order of menu, when computing the config options #2159

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Apr 27, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This will change the output sorting when calling the boards details.

What is the current behavior?

When launching the arduino-cli boards details -b esp8266:esp8266:generic --format json the order of the
config options doesn't follow the order of the menu declared in the first lines of boards.txt file.

What is the new behavior?

We now ensure that the order of the config options are following the order of the menus fields declared at the beginning of boards.txt

Does this PR introduce a breaking change, and is titled accordingly?

Nope

Other information

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@alessio-perugini alessio-perugini self-assigned this Apr 27, 2023
@alessio-perugini alessio-perugini added the type: enhancement Proposed improvement label Apr 27, 2023
@alessio-perugini alessio-perugini linked an issue Apr 27, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (2c2a5cc) 62.51% compared to head (0fbb88a) 62.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   62.51%   62.45%   -0.07%     
==========================================
  Files         224      224              
  Lines       19520    19646     +126     
==========================================
+ Hits        12203    12269      +66     
- Misses       6222     6279      +57     
- Partials     1095     1098       +3     
Flag Coverage Δ
unit 62.45% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/board.go 93.89% <100.00%> (+0.24%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! I think we can improve it a bit, I left some comments.

IMHO this PR can be removed from the draft state.

arduino/cores/board.go Outdated Show resolved Hide resolved
@alessio-perugini alessio-perugini marked this pull request as ready for review April 27, 2023 14:36
@alessio-perugini alessio-perugini merged commit ad9ddb8 into master Apr 27, 2023
@alessio-perugini alessio-perugini deleted the fix/board-details-output branch April 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align BoardDetailsResponse#config_options order with Java IDE
3 participants