-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the order of menu, when computing the config options #2159
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 62.51% 62.45% -0.07%
==========================================
Files 224 224
Lines 19520 19646 +126
==========================================
+ Hits 12203 12269 +66
- Misses 6222 6279 +57
- Partials 1095 1098 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! I think we can improve it a bit, I left some comments.
IMHO this PR can be removed from the draft state.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
This will change the output sorting when calling the boards details.
What is the current behavior?
When launching the
arduino-cli boards details -b esp8266:esp8266:generic --format json
the order of theconfig options doesn't follow the order of the menu declared in the first lines of
boards.txt
file.What is the new behavior?
We now ensure that the order of the config options are following the order of the menus fields declared at the beginning of
boards.txt
Does this PR introduce a breaking change, and is titled accordingly?
Nope
Other information