Skip to content

fix: redirect postinstall script output to runtime output #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 10, 2023
Merged

fix: redirect postinstall script output to runtime output #2090

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
66778a2
fix: redirect postinstall script output to runtime output
Bikappa Feb 27, 2023
0929b19
Merge branch 'master' into fix/postinstall-output
Bikappa Feb 27, 2023
634a826
Merge branch 'master' into fix/postinstall-output
Bikappa Feb 28, 2023
4ae9826
fix: use managed output stream
Bikappa Mar 2, 2023
1a71de8
updated dep licenses
Bikappa Mar 2, 2023
765d01d
Merge branch 'master' into fix/postinstall-output
Bikappa Mar 2, 2023
1bc3537
fix: log in feedback stream
Bikappa Mar 2, 2023
b7f2357
previous deps
Bikappa Mar 2, 2023
17ab168
fix failing test
Bikappa Mar 2, 2023
b093ec6
Merge branch 'master' into fix/postinstall-output
Bikappa Mar 7, 2023
9d07bf2
Merge branch 'master' into fix/postinstall-output
Bikappa Mar 10, 2023
a4fd58d
fix: dots after message
Bikappa Mar 10, 2023
023612b
Merge branch 'master' into fix/postinstall-output
Bikappa Mar 10, 2023
dbca859
chore: rm empty line
Bikappa Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into fix/postinstall-output
  • Loading branch information
@Bikappa
Bikappa authored Mar 7, 2023
commit b093ec6c1e5b51dbc6d35198ddf7dfea76128ccd
5 changes: 2 additions & 3 deletions internal/integrationtest/core/core_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ func TestCoreSearchNoArgs(t *testing.T) {
lines = append(lines, strings.Fields(strings.TrimSpace(v)))
}
// The header is printed on the first lines
// TODO: make test more resilient (no hardcoded line number)
require.Equal(t, []string{"test:x86", "2.0.0", "test_core"}, lines[21])
numPlatforms := len(lines) - 1

Expand All @@ -179,8 +178,8 @@ func TestCoreSearchNoArgs(t *testing.T) {
lines = append(lines, strings.Fields(strings.TrimSpace(v)))
}
// The header is printed on the first lines
// TODO: make test more resilient (no hardcoded line number)
require.Equal(t, []string{"test:x86", "2.0.0", "test_core"}, lines[22])

require.Equal(t, []string{"test:x86", "3.0.0", "test_core"}, lines[22])
numPlatforms = len(lines) - 1

// same thing in JSON format, also check the number of platforms found is the same
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.