fix: discovery cleanup and watchers continuity upon core install #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bikappa
force-pushed
the
discoveries_fix
branch
2 times, most recently
from
2df98f1 to
6074df3
Compare
Bikappa
commented
Feb 3, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
+ Coverage 36.57% 36.70% +0.12%
==========================================
Files 229 229
Lines 19630 19646 +16
==========================================
+ Hits 7180 7211 +31
+ Misses 11605 11592 -13
+ Partials 845 843 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Bikappa
force-pushed
the
discoveries_fix
branch
from
7e6f932 to
02f6d35
Compare
cmaglie
requested changes
Feb 27, 2023
Bikappa
force-pushed
the
discoveries_fix
branch
3 times, most recently
from
43cdaff to
e79909b
Compare
cmaglie
requested changes
Mar 8, 2023
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Bikappa
force-pushed
the
discoveries_fix
branch
from
262904c to
61ac16a
Compare
cmaglie
approved these changes
Mar 14, 2023
kittaakos
pushed a commit
to kittaakos/arduino-cli
that referenced
this pull request
Mar 21, 2023
…uino#2062) Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
It introduces a teardown of the running discovery processes when installing a new core, restarting them after to keep the watchers receiving events.
What is the current behavior?
When a new core is installed the running discovery processes are not terminated. Alive watchers freeze and don't receive any new events.
What is the new behavior?
When a new core is installed all running discovery processes are terminated, also those not interested by the update. They are restarted after the installation completed and watchers are reconnected to the new stream of events.
Connected boards face first a "remove" and then an "add" event.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fixes #1960
Fixes #1588