Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Online Help link to gRPC interface's Platform #2009

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code enhancement

What is the current behavior?

The Online Help link present in the package-index.json cannot be retrieved.

What is the new behavior?

It is possible to have access to Online Help using core search --format json.

PS C:\Users\m.pologruto\Desktop\Arduino\arduino-cli> .\arduino-cli core search avr --format json
[
...
{
   "id": "littleBits:avr",
   "latest": "1.0.0",
   "name": "littleBits Arduino AVR Modules",
   "maintainer": "littleBits Electronics",
   "website": "http://www.littlebits.cc/bits/w6-arduino",
   "email": "support@littlebits.cc",
   "boards": [
     {
       "name": "littleBits w6 Arduino module"
     }
   ],
   "type": [
     "Arduino@Heart"
   ],
   "help": {
     "online": "http://www.littlebits.cc/arduino-help"
   }
 }
]

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 14, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 14, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boards Manager does not have "Online help" links
4 participants