Skip to content

Prevent duplicate entries in board_manager.additional_urls #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Prevent duplicate entries in board_manager.additional_urls #1902

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
861919e
uniquify configuration arrays in `config add`
henrygab Oct 2, 2022
9fb7b17
Add tests for unique board manager URLs
henrygab Oct 2, 2022
370f637
fix linting
henrygab Oct 2, 2022
24acf27
lint: update function name
henrygab Oct 2, 2022
dd85466
update config set to uniquify slices
henrygab Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting
  • Loading branch information
@henrygab
henrygab committed Oct 2, 2022
commit 370f637e17aead9f5058607706ad1b1982c84854
1 change: 1 addition & 0 deletions test/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ def test_set_slice_with_multiple_arguments(run_command):
assert urls[5] in settings_json["board_manager"]["additional_urls"]
assert urls[6] in settings_json["board_manager"]["additional_urls"]


def test_set_string_with_single_argument(run_command):
# Create a config file
assert run_command(["config", "init", "--dest-dir", "."])
Expand Down