Skip to content

Add windows .msi installer to the CI #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 17, 2022
Merged

Add windows .msi installer to the CI #1899

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2fa0053
add step to generate a windows msi installer of the Arduino CLI
umbynos Sep 30, 2022
7fb4887
remove warning:
umbynos Sep 14, 2022
4bc4895
fix error caused by wix peculiar version constraints:
umbynos Sep 14, 2022
e77e6f0
fix `error LGHT0103: The system cannot find the file 'arduino-cli.exe'`
umbynos Sep 15, 2022
d16b8cc
final adjustments in wix config
umbynos Sep 30, 2022
fab6412
exclude prettier from checking the installer config files, prettier d…
umbynos Sep 30, 2022
9cbfe14
add download links
umbynos Sep 30, 2022
598c334
temporarily disable s3 push and homebrew update for testing
umbynos Sep 14, 2022
ce7456f
Upload nightly artifacts for testing
umbynos Sep 30, 2022
4f0ee9c
add windows check certs
umbynos Oct 5, 2022
b3472ff
bump to latest windows-sdk and document better
umbynos Oct 5, 2022
480372d
remove useless job id not used anymore (followup of #1883)
umbynos Oct 5, 2022
78cb662
fixed comments
umbynos Oct 5, 2022
1d3bedf
It's useless to use the output from setupmsbuild
umbynos Oct 5, 2022
0fa0023
use YAML-style syntax
umbynos Oct 6, 2022
f302f9f
try to uniform the usage of version/tag across the workflow
umbynos Oct 5, 2022
5274f2d
Revert "Upload nightly artifacts for testing" && "temporarily disable…
umbynos Sep 30, 2022
09c64e6
Apply suggestions from code review
umbynos Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix error LGHT0103: The system cannot find the file 'arduino-cli.exe'
  • Loading branch information
@umbynos
umbynos committed Oct 17, 2022
commit e77e6f031672a1b694277d3ebadc7921cd176358
4 changes: 2 additions & 2 deletions .github/workflows/release-go-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ jobs:
TAG="${GITHUB_REF/refs\/tags\//}"
WIX_TAG="${TAG%%-*}" # removes "-rc*" since wix is not happy with it, this only affects RCs builds (error CNDL0108)
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_Windows_64bit"
SOURCE_DIR="${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_windows_amd64/${{ env.PROJECT_NAME }}.exe"
"${{ env.MSBUILD_PATH }}\MSBuild.exe" ./installer/cli.wixproj -p:SourceDir="$SOURCE_DIR" -p:OutputPath="${{ env.DIST_DIR }}" -p:OutputName="$PACKAGE_FILENAME" -p:ProductVersion="$WIX_TAG"
SOURCE_DIR="${GITHUB_WORKSPACE}/${{ env.DIST_DIR }}/${{ env.PROJECT_NAME }}_windows_amd64/"
"${{ env.MSBUILD_PATH }}\MSBuild.exe" ./installer/cli.wixproj -p:SourceDir="$SOURCE_DIR" -p:OutputPath="${GITHUB_WORKSPACE}/${{ env.DIST_DIR }}" -p:OutputName="$PACKAGE_FILENAME" -p:ProductVersion="$WIX_TAG"

- name: Save Win signing certificate to file
run: echo "${{ secrets.INSTALLER_CERT_WINDOWS_PFX }}" | base64 --decode > ${{ env.INSTALLER_CERT_WINDOWS_PFX}}
Expand Down