- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 432
[breaking] Removed redundant and useless commands from gRPC API #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    4bfd5ab    to
    bc2d934      
    Compare
  
    
              
                    umbynos
  
              
              approved these changes
              
                  
                    Oct 21, 2022 
                  
              
              
            
            
This will turn out useful in the following commits
Unfortunately we cannot limit the availability of the cli.core.* package to the cli.* packages, but they are now available as public API.
They are printed directly inside the function through the feedback package.
bc2d934    to
    a9f48de      
    Compare
  
    
              
                    umbynos
  
              
              approved these changes
              
                  
                    Oct 24, 2022 
                  
              
              
            
            
      
        
      
      
  
    6 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    criticality: low
  Of low impact 
  
    priority: high
  Resolution is a high priority 
  
    topic: gRPC
  Related to the gRPC interface 
  
    type: enhancement
  Proposed improvement 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Removes the gRPC commands:
The code for these cli commands (execution, rendering, error reporting...) is duplicated from 2 to 3 times.
Removed all code duplication.
titled accordingly?
Yes, the gRPC API calls described above have been removed.