-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Implementation of sketch profiles #1713
Conversation
fe3ed29
to
5e3a93f
Compare
544b0aa
to
7dd09e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sketch-profiles.md
should be added to the nav[]
key in /mkdocs.yml
so that the page is listed in the navigation panel of the documentation website. I recommend placing it after the "Sketch Specification" page:
Line 109 in 6883b39
- sketch-specification.md |
I've also renamed |
c796fa4
to
5bd294f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmaglie and to the other contributors for this valuable advancement for the Arduino project.
The failing link check for https://www.arduino.cc/en/Reference/APIStyleGuide is unrelated to the changes made in this PR. I am monitoring that and will take action if needed to get the correct redirect set up.
Makes it more future-proof in case of further expasion
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Just rebased on master to fix the dead link, we should be all-green in a couple of minutes 🥳 |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This PR implements Profiles.
In the long run, profiles will eventually replace and deprecate
sketch.json
.Does this PR introduce a breaking change, and is titled accordingly?
This PR introduces breaking changes in the golang API and the cli behavior.