Board identification improvements #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
topic: CLI
cmaglie
force-pushed
the
board_identification_improvements
branch
from
226dffc to
01611d7
Compare
It required insertion of test data with the properties.Set method to preserve ordering.
cmaglie
force-pushed
the
board_identification_improvements
branch
from
01611d7 to
c1cee78
Compare
cmaglie
force-pushed
the
board_identification_improvements
branch
from
c1cee78 to
1bcdd33
Compare
per1234
requested changes
Oct 14, 2022
Co-authored-by: per1234 <accounts@perglass.com>
|
Thanks for fixing my poor documentation @per1234 :-) |
per1234
approved these changes
Oct 17, 2022
umbynos
approved these changes
Oct 18, 2022
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This PR adds the possibility to the
board listcommand to detect the board FQBN with full configuration (the configuration it's the last portion of the FQBN i.e.:arduino:avr:mega:CONF=VALUE)What is the current behavior?
The
board listcommand can not detect the board configuration.What is the new behavior?
The
board listcommand may return the full FQBN including the board configuration if the platforms correctly support it.Does this PR introduce a breaking change, and is
titled accordingly?
The
fqbnreturned from the board list command now may contain also the config partarduino:avr:mega:CONF=VALUE,.... Strictly speaking, it's not a breaking change, since the FQBN is supposed to contain this (optional) configuration part. BTW this is very uncommon so the clients parsing the FQBN may not be ready to handle this optional piece.Other information:
Some other improvements on subroutines handling boards metadata have been made, with many pieces refactored to improve source code readability.