- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 431
Better gRPC error handling #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      b7e8ff4
              
                Proper gRPC error handling
              
              
                cmaglie b6522c0
              
                Update gRPC API of board command to return status.Status instead of e…
              
              
                per1234 67c19f2
              
                Update gRPC API of remaining commands to return status.Status instead…
              
              
                per1234 17652b6
              
                Replace custom error with protobuf message
              
              
                per1234 c6b72b9
              
                Handle details of any type in `core.PlatformUpgrade()` status
              
              
                per1234 4696d07
              
                Return nil on program action if an error occurred
              
              
                cmaglie acf791e
              
                Refactoring 'upload' commands
              
              
                cmaglie 4fa1080
              
                Refactoring 'board' commands
              
              
                cmaglie ce3f802
              
                Refactoring 'compile' commands
              
              
                cmaglie 5890cb2
              
                Refactoring 'core' commands
              
              
                cmaglie 0195111
              
                Refactoring 'debug' commands
              
              
                cmaglie 1025981
              
                Refactoring 'lib' commands
              
              
                cmaglie 1e770ca
              
                Refactoring 'sketch' commands
              
              
                cmaglie 677fd55
              
                Refactoring 'commands' commands
              
              
                cmaglie 763fcb8
              
                updated tests and fixed some error wording
              
              
                cmaglie 50d17c4
              
                fixed go lint warnings
              
              
                cmaglie 89a61df
              
                Apply suggestions from code review
              
              
                cmaglie 4bcaf9c
              
                Apply changes from code review
              
              
                cmaglie 6bf77b9
              
                fix i18n
              
              
                cmaglie File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
       Handle details of any type in 
    core.PlatformUpgrade() status
    The status details of the function are used to identify the specific cause of a non-nil status. This is done via a type assertion. Previously, this type assertion was configured such that a details of any type other than the expected would result in a panic. At the moment, that will not occur because we only add details of one type. However, the whole point of the type assertion is to support details of multiple types, and if other types are added a panic will not be the appropriate behavior. A better approach is to check the result of the type assertion, handling the non-nil status as a generic error if its details are of a different type.
- Loading branch information
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.