Skip to content

Added flag to disable check for sketch foldername matching sketch name #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Added flag to disable check for sketch foldername matching sketch name #1187

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26f2fa4
Added flag to disable check for sketch foldername
cmaglie Feb 15, 2021
78d14c0
Added missing source doc
cmaglie Feb 15, 2021
52219f7
Changed module sketch_test -> sketch
cmaglie Feb 16, 2021
9fc78c7
Fixed test
cmaglie Feb 16, 2021
f6fcd7a
Return the detected sketch as part of the error
cmaglie Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed test
  • Loading branch information
@cmaglie
cmaglie committed Feb 16, 2021
commit 9fc78c772e2e3c32685aaf9bfccaf4c99c1865ac
4 changes: 3 additions & 1 deletion arduino/sketch/sketch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ func TestNewSketchCasingWrong(t *testing.T) {
sketchPath := paths.New("testdata", "SketchCasingWrong")
mainFilePath := paths.New("testadata", "sketchcasingwrong.ino").String()
sketch, err := New(sketchPath.String(), mainFilePath, "", []string{mainFilePath})
assert.Nil(t, sketch)
assert.NotNil(t, sketch)
assert.Error(t, err)
assert.IsType(t, &InvalidSketchFoldernameError{}, err)
expectedError := fmt.Sprintf("no valid sketch found in %s: missing %s", sketchPath.String(), sketchPath.Join(sketchPath.Base()+".ino"))
assert.EqualError(t, err, expectedError)
}
Expand Down