Skip to content

Integration of arduino-preprocessor #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 8, 2017

No description provided.

@per1234
Copy link
Contributor

per1234 commented Jun 8, 2017

I replaced the arduino-builder.exe included with Arduino IDE 1.8.3 with http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-232.zip and now I get the following error when trying to compile any sketch:

arduino-preprocessor pattern is missing

Verbose output in the IDE console:

Arduino: 1.8.3 (Windows 7), Board: "Arduino/Genuino Uno"

E:\ArduinoIDE\arduino-1.8.3\arduino-builder -dump-prefs -logger=machine -hardware E:\ArduinoIDE\arduino-1.8.3\hardware -hardware C:\Users\per\AppData\Local\Arduino15\packages -hardware E:\Stuff\misc\electronics\arduino\hardware -tools E:\ArduinoIDE\arduino-1.8.3\tools-builder -tools E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -tools C:\Users\per\AppData\Local\Arduino15\packages -built-in-libraries E:\ArduinoIDE\arduino-1.8.3\libraries -libraries E:\Stuff\misc\electronics\arduino\libraries -fqbn=arduino:avr:uno -ide-version=10803 -build-path C:\Users\per\AppData\Local\Temp\arduino_build_234858 -warnings=all -build-cache C:\Users\per\AppData\Local\Temp\arduino_cache_441904 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.arduinoOTA.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -prefs=runtime.tools.avr-gcc.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -prefs=runtime.tools.avrdude.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -verbose E:\ArduinoIDE\arduino-1.8.3\examples\01.Basics\BareMinimum\BareMinimum.ino
E:\ArduinoIDE\arduino-1.8.3\arduino-builder -compile -logger=machine -hardware E:\ArduinoIDE\arduino-1.8.3\hardware -hardware C:\Users\per\AppData\Local\Arduino15\packages -hardware E:\Stuff\misc\electronics\arduino\hardware -tools E:\ArduinoIDE\arduino-1.8.3\tools-builder -tools E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -tools C:\Users\per\AppData\Local\Arduino15\packages -built-in-libraries E:\ArduinoIDE\arduino-1.8.3\libraries -libraries E:\Stuff\misc\electronics\arduino\libraries -fqbn=arduino:avr:uno -ide-version=10803 -build-path C:\Users\per\AppData\Local\Temp\arduino_build_234858 -warnings=all -build-cache C:\Users\per\AppData\Local\Temp\arduino_cache_441904 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.arduinoOTA.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -prefs=runtime.tools.avr-gcc.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -prefs=runtime.tools.avrdude.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -verbose E:\ArduinoIDE\arduino-1.8.3\examples\01.Basics\BareMinimum\BareMinimum.ino
Using board 'uno' from platform in folder: E:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr
Using core 'arduino' from platform in folder: E:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr
Detecting libraries used...
"E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -flto -w -x c++ -E -CC -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10803 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR   "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\cores\arduino" "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\variants\standard" "C:\Users\per\AppData\Local\Temp\arduino_build_234858\sketch\BareMinimum.ino.cpp" -o "nul"
Generating function prototypes...
"E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -flto -w -x c++ -E -CC -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10803 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR   "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\cores\arduino" "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\variants\standard" "C:\Users\per\AppData\Local\Temp\arduino_build_234858\sketch\BareMinimum.ino.cpp" -o "C:\Users\per\AppData\Local\Temp\arduino_build_234858\preproc\ctags_target_for_gcc_minus_e.cpp"
arduino-preprocessor pattern is missing

Error compiling for board Arduino/Genuino Uno.

Output when run from command line with -debug-level=10 option added:

E:\Stuff>E:\ArduinoIDE\arduino-1.8.3\arduino-builder -compile -logger=machine -hardware E:\ArduinoIDE\arduino-1.8.3\hardware -hardware C:\Users\per\AppData\Local\Arduino15\packages -hardware E:\Stuff\
misc\electronics\arduino\hardware -tools E:\ArduinoIDE\arduino-1.8.3\tools-builder -tools E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -tools C:\Users\per\AppData\Local\Arduino15\packages -built-in-
libraries E:\ArduinoIDE\arduino-1.8.3\libraries -libraries E:\Stuff\misc\electronics\arduino\libraries -fqbn=arduino:avr:uno -ide-version=10803 -build-path C:\Users\per\AppData\Local\Temp\arduino_buil
d_234858 -warnings=all -build-cache C:\Users\per\AppData\Local\Temp\arduino_cache_441904 -prefs=build.warn_data_percentage=75 -prefs=runtime.tools.arduinoOTA.path=E:\ArduinoIDE\arduino-1.8.3\hardware\
tools\avr -prefs=runtime.tools.avr-gcc.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -prefs=runtime.tools.avrdude.path=E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr -verbose -debug-level=10 E:\
ArduinoIDE\arduino-1.8.3\examples\01.Basics\BareMinimum\BareMinimum.ino
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 GenerateBuildPathIfMissing]
===info ||| Progress {0} ||| [0.00]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 EnsureBuildPathExists]
===info ||| Progress {0} ||| [2.94]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 ContainerSetupHardwareToolsLibsSketchAndProps]
===info ||| Progress {0} ||| [5.88]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 AddAdditionalEntriesToContext]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 FailIfBuildPathEqualsSketchPath]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 HardwareLoader]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 PlatformKeysRewriteLoader]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 RewriteHardwareKeys]
===debug ||| Ts: {0} - Running: {1} ||| [1496962525 ToolsLoader]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 TargetBoardResolver]
===info ||| Using board '{0}' from platform in folder: {1} ||| [uno E%3A%5CArduinoIDE%5Carduino-1.8.3%5Chardware%5Carduino%5Cavr]
===info ||| Using core '{0}' from platform in folder: {1} ||| [arduino E%3A%5CArduinoIDE%5Carduino-1.8.3%5Chardware%5Carduino%5Cavr]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 AddBuildBoardPropertyIfMissing]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 LibrariesLoader]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 SketchLoader]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 SetupBuildProperties]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 LoadVIDPIDSpecificProperties]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 SetCustomBuildProperties]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 AddMissingBuildPropertiesFromParentPlatformTxtFiles]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 ContainerBuildOptions]
===info ||| Progress {0} ||| [8.82]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 CreateBuildOptionsMap]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 LoadPreviousBuildOptionsMap]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 WipeoutBuildPathIfBuildOptionsChanged]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 StoreBuildOptionsMap]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 WarnAboutPlatformRewrites]
===info ||| Progress {0} ||| [11.76]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 RecipeByPrefixSuffixRunner]
===info ||| Progress {0} ||| [14.71]
===debug ||| Looking for recipes like {0}*{1} ||| [recipe.hooks.prebuild .pattern]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 ContainerMergeCopySketchFiles]
===info ||| Progress {0} ||| [17.65]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 SketchSourceMerger]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 SketchSaver]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 AdditionalSketchFilesCopier]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 loggerAction]
===info ||| Progress {0} ||| [20.59]
===info ||| Detecting libraries used... ||| []
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 ContainerFindIncludes]
===info ||| Progress {0} ||| [23.53]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 GCCPreprocRunnerForDiscoveringIncludes]
"E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -flto -w -x c++ -E -CC -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10803 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR   "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\cores\arduino" "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\variants\standard" "C:\Users\per\AppData\Local\Temp\arduino_build_234858\sketch\BareMinimum.ino.cpp" -o "nul"
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 IncludesFinderWithRegExp]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 FailIfImportedLibraryIsWrong]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 WarnAboutArchIncompatibleLibraries]
===info ||| Progress {0} ||| [26.47]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 loggerAction]
===info ||| Progress {0} ||| [29.41]
===info ||| Generating function prototypes... ||| []
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 PreprocessSketch]
===info ||| Progress {0} ||| [32.35]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 GCCPreprocRunner]
"E:\ArduinoIDE\arduino-1.8.3\hardware\tools\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -flto -w -x c++ -E -CC -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10803 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR   "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\cores\arduino" "-IE:\ArduinoIDE\arduino-1.8.3\hardware\arduino\avr\variants\standard" "C:\Users\per\AppData\Local\Temp\arduino_build_234858\sketch\BareMinimum.ino.cpp" -o "C:\Users\per\AppData\Local\Temp\arduino_build_234858\preproc\ctags_target_for_gcc_minus_e.cpp"
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 ArduinoPreprocessorRunner]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 PrintUsedAndNotUsedLibraries]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 PrintUsedLibrariesIfVerbose]
===debug ||| Ts: {0} - Running: {1} ||| [1496962532 Sizer]
===error ||| {0} pattern is missing ||| [arduino-preprocessor]

*errors.errorString
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/i18n/errors.go:10 (0x4ad8bd)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/preprocess_sketch.go:87 (0x4a0d5b)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/preprocess_sketch.go:59 (0x4a087a)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/builder.go:191 (0x493f72)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/builder.go:124 (0x4939df)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/builder/builder.go:222 (0x494565)
/home/jenkins/jenkins/jobs/arduino-builder-pr-builder/workspace/src/arduino.cc/arduino-builder/main.go:342 (0x402fdd)
/opt/go/src/runtime/proc.go:183 (0x42b7fe)
/opt/go/src/runtime/asm_386.s:1612 (0x451e11)

@cmaglie
Copy link
Member Author

cmaglie commented Jun 9, 2017

Hi @per1234

you need a build of the Arduino IDE with the right tools installed, I'm preparing it.

This PR was to try to run the tests on travis that seems unable to run the arduino-preprocessor tool 😞, something to investigate.

@arduino arduino deleted a comment from ArduinoBot Jun 25, 2017
@arduino arduino deleted a comment from ArduinoBot Jun 25, 2017
@arduino arduino deleted a comment from ArduinoBot Jun 25, 2017
@arduino arduino deleted a comment from ArduinoBot Jun 25, 2017
@arduino arduino deleted a comment from ArduinoBot Jul 25, 2017
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@facchinm facchinm force-pushed the preprocessor branch 2 times, most recently from b41ff1d to 26fa47d Compare August 3, 2017 10:34
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@facchinm facchinm force-pushed the preprocessor branch 2 times, most recently from 7317f8a to 9bb2743 Compare August 3, 2017 10:55
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@arduino arduino deleted a comment from ArduinoBot Aug 3, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-232.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@arduino arduino deleted a comment from ArduinoBot Jan 11, 2018
@arduino arduino deleted a comment from ArduinoBot Jan 11, 2018
@facchinm
Copy link
Member

Integrated manually in 1.4.0

@facchinm facchinm closed this Jun 12, 2018
@cmaglie cmaglie deleted the preprocessor branch September 10, 2018 08:52
@cmaglie cmaglie added this to the 1.4.0 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants