Skip to content

Add CI workflows (to be used with ArduinoCore-API integration) #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Nov 25, 2020
Merged

Add CI workflows (to be used with ArduinoCore-API integration) #567

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
cc557a4
Add compile example for CI
giulcioffi Sep 1, 2020
2691b30
Use branch namespaced_api_Hardware of ArduinoCore-API
giulcioffi Sep 2, 2020
64f2aee
Disable size-delta-report and use arduino path for compile example step
giulcioffi Sep 2, 2020
3139e35
Use official branch of ArduinoCore-API
giulcioffi Oct 15, 2020
f7c8d00
Add MKRGSM, MKRNB, MKRWAN, WiFi101
giulcioffi Sep 2, 2020
e9e9e8b
Compile all the libraries + WiFi101 from namespaced_api branch
giulcioffi Sep 2, 2020
1a6ef45
Install ArduinoIoTCloud + dependencies from the repository instead of…
giulcioffi Sep 3, 2020
7d18af8
Install Arduino_ConnectionHandler from the repository instead of Boar…
giulcioffi Sep 3, 2020
0ed98c2
Compile LoRa library
giulcioffi Sep 3, 2020
4f861fd
Remove intallation of libraries which are dependencies of ArduinoIoTC…
giulcioffi Sep 4, 2020
c3f8a97
Compile only when a relevant file is modified
giulcioffi Sep 10, 2020
c8693a3
Remove examples from extras and add step to download them
giulcioffi Sep 10, 2020
0bff8ae
Use list mode for sketches
giulcioffi Sep 10, 2020
00dca72
Remove universal libraries entry
giulcioffi Sep 10, 2020
f2dd55a
Remove WiFiNINA step and compile its examples
giulcioffi Sep 10, 2020
2990e4c
Assign a unique type to mkrwifi1010, nano33IoT, mkrwan1310 and mkrNB1500
giulcioffi Sep 10, 2020
6db378e
Remove comments
giulcioffi Sep 10, 2020
d7d471b
Add report-size-delta action + step to upload artifact
giulcioffi Oct 15, 2020
01f3e74
Update names and paths for compile-sketches and report-size-deltas ac…
giulcioffi Oct 16, 2020
b47b2af
Add VidorPeripherals to tesk sketches for MKR Vidor
giulcioffi Nov 23, 2020
da63a92
Use master branch of library WiFi101
giulcioffi Nov 23, 2020
dbf2e79
Use new mkrgsm1400-sketch-paths for MKR GSM1400
giulcioffi Nov 23, 2020
857c994
Update inputs for upload-artifact entries
giulcioffi Nov 23, 2020
0dc7e00
Add WAN attribute to compile also examples from MKRWAN library for MK…
giulcioffi Nov 23, 2020
fb59c13
Remove redundant matrix entry for MKRNB1500
giulcioffi Nov 23, 2020
50d5867
Use release version of Keyboard library
giulcioffi Nov 23, 2020
6769704
Fix wrong core name in a comment
giulcioffi Nov 23, 2020
e62bb96
Mv ArduinoCore-API only if included inplatform
giulcioffi Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add MKRGSM, MKRNB, MKRWAN, WiFi101
  • Loading branch information
@giulcioffi
giulcioffi committed Oct 15, 2020
commit f7c8d00b13b58ad653eeac3ab99d136aa9c6e7a4
20 changes: 20 additions & 0 deletions .github/workflows/compile-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,22 @@ jobs:
- board:
type: "tian"
additional-sketch-paths: '"~/Arduino/libraries/Firmata/examples/StandardFirmataPlus" "~/Arduino/libraries/Firmata/examples/StandardFirmataEthernet" "~/Arduino/libraries/Firmata/examples/StandardFirmata" "~/Arduino/libraries/Firmata/examples/SimpleDigitalFirmata" "~/Arduino/libraries/Firmata/examples/SimpleAnalogFirmata" "~/Arduino/libraries/Firmata/examples/ServoFirmata" "~/Arduino/libraries/Firmata/examples/EchoString" "~/Arduino/libraries/Firmata/examples/AnalogFirmata" "~/Arduino/libraries/Firmata/examples/AllInputsFirmata"'
# MKRGSM1400 board
- board:
fqbn: "arduino:samd:mkrgsm1400"
additional-sketch-paths: "~/Arduino/libraries/MKRGSM/examples"
# MKRNB1500 board
- board:
fqbn: "arduino:samd:mkrnb1500"
additional-sketch-paths: "~/Arduino/libraries/MKRNB/examples"
# MKRWAN board
- board:
fqbn: '"arduino:samd:mkrwan1300" "arduino:samd:mkrwan1310"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since none of the existing matrix items match the matrix.include filter, this creates a new matrix element.
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#example-including-new-combinations
You can see the fqbn: '"arduino:samd:mkrwan1300" "arduino:samd:mkrwan1310"' job here;
https://github.com/giulcioffi/ArduinoCore-samd/runs/1263161214
and the jobs for the fqbn: arduino:samd:mkrwan1300 and fqbn: arduino:samd:mkrwan1310 matrix elements:
https://github.com/giulcioffi/ArduinoCore-samd/runs/1263161020
https://github.com/giulcioffi/ArduinoCore-samd/runs/1263161034

Apparently the arduino/compile-sketches action accepts the input fqbn: "arduino:samd:mkrwan1300" "arduino:samd:mkrwan1310"and ends up just compiling only for the MKR WAN 1300.

You could add a general "WAN" attribute property to the matrix, something like what I did in this workflow:
https://github.com/arduino/arduino-examples/blob/main/.github/workflows/compile-examples.yml
The only problem is that, as you see here, when no matrix element matches the filter, one is created, which is why I had to define those properties for all the boards in the matrix, rather than only for the boards the property applied to.

You could also just add a separate matrix.include filter for each of the MKR WAN boards board.fqbn values.

This also has the same issue as I described above for arduino:samd:mkrgsm1400 of overwriting the previous value of additional-sketch-paths for arduino:samd:mkrwan1300.

additional-sketch-paths: "~/Arduino/libraries/MKRWAN/examples"
# WiFi101
- board:
type: "usb"
additional-sketch-paths: "~/Arduino/libraries/WiFi101/examples"

steps:
- name: Checkout repository
Expand Down Expand Up @@ -135,6 +151,10 @@ jobs:
- name: Temboo
- name: ArduinoIoTCloud
- name: Madgwick
- name: MKRGSM
- name: MKRNB
- name: MKRWAN
- name: WiFi101
platforms: |
# Use Board Manager to install the latest release of Arduino megaAVR Boards to get the toolchain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Use Board Manager to install the latest release of Arduino megaAVR Boards to get the toolchain
# Use Board Manager to install the latest release of Arduino SAMD Boards to get the toolchain

- name: "arduino:samd"
Expand Down