Fixed software serial library inspired by .org #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
suggested changes
Mar 31, 2019
| * RX is digital pin 10 (connect to TX of other device) | ||
| * TX is digital pin 11 (connect to RX of other device) | ||
|
|
||
| Note: |
There was a problem hiding this comment.
I would suggest removing the comments about the allowed pins on the AVR boards on lines 11-19, since it's not relevant here.
libraries/SoftwareSerial/examples/SoftwareSerialExample/SoftwareSerialExample.ino
Outdated
Show resolved
Hide resolved
| * First serial device's TX attached to digital pin 10(RX), RX to pin 11(TX) | ||
| * Second serial device's TX attached to digital pin 8(RX), RX to pin 9(TX) | ||
|
|
||
| Note: |
There was a problem hiding this comment.
I would suggest removing the comments about the allowed pins on the AVR boards on lines 19-27, since it's not relevant here.
libraries/SoftwareSerial/examples/TwoPortReceive/TwoPortReceive.ino
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
|
|
…reSerialExample.ino Co-Authored-By: agdl <a.guadalupi@arduino.cc>
…e.ino Co-Authored-By: agdl <a.guadalupi@arduino.cc>
…e.ino Co-Authored-By: agdl <a.guadalupi@arduino.cc>
Co-Authored-By: agdl <a.guadalupi@arduino.cc>
…e.ino Co-Authored-By: agdl <a.guadalupi@arduino.cc>
Co-Authored-By: agdl <a.guadalupi@arduino.cc>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I fixed the Software Serial library for SAMD boards .org guys made here
https://github.com/arduino-org/Arduino/tree/master/hardware/arduino/samd/libraries/SoftwareSerial
It works fine at 9600 with different boards.
Feedback and improvements will be very welcome :)