Skip to content

Add Non-blocking Version of localIP Function for WiFiS3 library and fix FifoBuffer.h #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Non-blocking Version of localIP Function for WiFiS3 library and fix FifoBuffer.h #408

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf77427
added non blocking delayless localIP function
MYusufY Nov 30, 2024
72ba7e5
fix return paths in FifoBuffer functions
MYusufY Dec 1, 2024
613ce96
add localIPNonBlocking to WiFi.h
MYusufY Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add localIPNonBlocking to WiFi.h
  • Loading branch information
@MYusufY
MYusufY authored Dec 1, 2024
commit 613ce96c8c06a7c0e11732d5db4b25d1951fc691
3 changes: 2 additions & 1 deletion libraries/WiFiS3/src/WiFi.h
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to override the functionality of localIP() instead of writing a new one. I think you had a good Idea to specify in the function signature the timeout, so I would keep it, but with the addition of making it default to _timeout value. Could you also modify the comment above accordingly?

Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ class CWifi {
* return: IP address value
*/
IPAddress localIP();

IPAddress localIPNonBlocking(unsigned long timeoutMs);

/*
* Get the interface subnet mask address.
*
Expand Down
Loading