Skip to content

Really bad code in Serial transmit interrupt driver #43

Closed
@egilkv

Description

@egilkv

There is a really bad while loop in the transmit interrupt driver that causes the CPU to spend most of its time looping with interrupts disabled in the interrupt driver.

I must say I was very surprised to find this, makes one wonder what other things went passed code review and testing?

Anyway, the fix is here: #42

I have attached a simple test program that shows just how serious this is (try it with and without the patch):
Test_serial_bug.txt
Another way to test is to transmit a lot on one or more serial channels and receive at the same time. You will loose a lot of characters.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions