-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement event handler for AP connections #79
Conversation
@sbhklr they can be retrieved from https://github.com/arduino/ArduinoCore-mbed/blob/master/cores/arduino/mbed/targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/COMPONENT_WHD/inc/whd_events.h#L42 . |
Memory usage change @ b5170bd
Click for full report table
Click for full report CSV
|
Memory usage change @ d025a70
Click for full report table
Click for full report CSV
|
782b41f
to
9efdc53
Compare
9efdc53
to
59e224d
Compare
There doesn't seem to be a way to call the default handler beforehand. The function is private and there is no API for retrieving any registered event handler (couldn't find one) which could be used to anonymously call the default handler. |
Memory usage change @ f3a2d60
Click for full report table
Click for full report CSV
|
@sbhklr copying the content of the default handler is fine, but since the function grew significantly I'd replace the lambda with a proper function pointer and extract it. What do you think? |
Memory usage change @ 300a533
Click for full report table
Click for full report CSV
|
@facchinm Fair enough, done. |
I've run into this issue as well trying to move code from an UNO over to an H7. When, very roughly, might this fix show up in a release. Thanks for finding and fixing the issue. |
I think we're ready to merge this one. |
@rchard-84 Have you tested this PR? It works on my end, but always good to have more testers :-) |
Ok for merging 🙂 Next release is due in a week more or less (after ARMmbed/mbed-os#13826 gets merged) |
I did not test the PR. I lack the knowhow to go from your fix to a
compiled library that I can test on the portenta. Is there a walk through
someplace? I'd be happy to try stuff out.
…On Mon, Nov 16, 2020, 2:29 AM Sebastian Romero ***@***.***> wrote:
@rchard-84 <https://github.com/rchard-84> Have you tested this PR? It
works on my end, but always good to have more testers :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#79 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOBFBJHF6RQ6LMNQEFUAJFLSQDIFFANCNFSM4S7UQ4NA>
.
|
@rchard-84 Basically you can check out this repository and put it in your sketchbook. Then you can select that version of the core from the menu in the IDE. There might be some documentation on that. @per1234 if anyone, then you'll know it :-) Any hints? |
As for the technique of using a copy of the core in the sketchbook for development/beta testing, there is an interesting discussion about it here: As for official documentation of the manual core installation process, there isn't any that I'm aware of beyond a quick mention in the Arduino Platform Specification (the preferred term for this is "platform"):
I would expect to find manual platform installation documented here: https://www.arduino.cc/en/Guide/Cores, but it only talks about Boards Manager installation. |
Thanks @per1234 ! I've asked content to add documentation to that page. |
Tries to solve #78
@facchinm I couldn't figure out where those events for connect/disconnect are defined so I went with the raw values. Any hints?