-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Removed compiler warnings (binary constants). #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Memory usage change @ 5c7b73a
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change.
Using hex instead of binary constants could be considered slightly less readable, though I think fixing the warnings is more important. Also, if we really care about readabilty, we should be using constants from avr/io.h anyway.
I've doublechecked the conversions for typos, looks good to me. I would be in favor of merging this trivial change.
This "patch" will result in the suppression of a number of warnings that are the result of the use of binary constants, which a are not supported in ISO C++11. In particular the following warnings are removed.
Note that these warnings only occur when using the
-pedantic
compiler option, which can be very useful for end users at times. So it would be nice if the user is not confronted with these warnings.